Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find tests in nested directories #355

Merged
merged 6 commits into from
Mar 30, 2017
Merged

Find tests in nested directories #355

merged 6 commits into from
Mar 30, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 30, 2017

This pull request splits general test and export structuring refactoring from #335 and #348 . Previously parser tests weren't being run because they were defined in a nested directory. Upon including those tests, errors began to occur due to circular dependencies in Webpack (see webpack/webpack#1788). The changes here resolve this by moving the registration behaviors into its own file so the dependency between the parser and registration is more direct. In doing so, the blocks folder was flattened to bring parser to the top-level directory.

@aduth aduth requested a review from youknowriad March 30, 2017 13:51
@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Mar 30, 2017
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants